Closed Bug 1629440 Opened 5 years ago Closed 5 years ago

VPXDecoder.cpp: converting integer literal to bool, use bool literal instead

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: Sylvestre, Assigned: tim.chenbw, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

Replace 1 by true (it is casted to bool anyway), on both lines as the two are boolean

https://searchfox.org/mozilla-central/source/dom/media/platforms/agnostic/VPXDecoder.cpp#473-474

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Assignee: nobody → tim.chenbw
Status: NEW → ASSIGNED

Hello Sylvestre,
My commit has passed the code review, so what should I do next ?

thanks for your help :)

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06d3318904d2 Replace 1 by true in VPXDecoder.cpp. r=jya

Thank you Sylvestre !

I have one more question.
Should I change the status of this bug to close ?

Thanks for your help :)

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: